J-HowHuang commented on code in PR #19230:
URL: https://github.com/apache/pinot/pull/19230#discussion_r3770742799
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java:
##########
@@ -151,9 +151,9 @@ public static Set<String>
getColumnsWithLegacyNativeTextIndex(File segDir, Colle
}
/// Names of the entries directly inside `dir`, files and directories alike
(a Lucene text index is
- /// a directory), or empty when it cannot be listed.
- private static Set<String> listEntryNames(File dir) {
- String[] names = dir.list();
+ /// a directory), or empty when `dir` is null or cannot be listed.
+ private static Set<String> listEntryNames(@Nullable File dir) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
