Jackie-Jiang commented on code in PR #19168:
URL: https://github.com/apache/pinot/pull/19168#discussion_r3771298687
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/MutableOffHeapByteArrayStore.java:
##########
@@ -233,6 +245,19 @@ public int getValueSize(int index) {
throw new RuntimeException("dictionary ID '" + index + "' too low");
}
+ /// Returns a view of the value at the given index without copying it.
+ /// The returned buffer must not be used after this store is closed.
+ public ByteBuffer getByteBuffer(int index) {
Review Comment:
(minor) Move this before `getValueSize()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
