Copilot commented on code in PR #19246:
URL: https://github.com/apache/pinot/pull/19246#discussion_r3776927844
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/ArrayTest.java:
##########
@@ -526,6 +526,45 @@ public void testStringSplitFunction(boolean
useMultiStageQueryEngine)
assertEquals(row.get(0).get(2).asText(), "t3");
}
+ @Test(dataProvider = "useBothQueryEngines")
+ public void testFoldedStringArrayLiteralWithIngestedColumn(boolean
useMultiStageQueryEngine)
+ throws Exception {
+ setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+ // Selecting an ingested column sends the single-stage query to the
servers, where the folded STRING_ARRAY literal
+ // is rendered. The returned column also verifies the Avro multi-value
STRING data was ingested correctly.
Review Comment:
This test runs with both query engines, but the comment mentions a
“single-stage query”. That’s misleading for the multi-stage engine case;
consider rephrasing to describe a table-backed query (with FROM / ingested
column) ensuring the folded STRING_ARRAY literal is rendered during result
construction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
