Copilot commented on code in PR #19249:
URL: https://github.com/apache/pinot/pull/19249#discussion_r3778524910
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java:
##########
@@ -240,6 +241,7 @@ private DimensionTable createFastLookupDimensionTable() {
}
Object[] primaryKey = recordReader.getRecordValues(i, pkIndexes);
+ primaryKey = wrapPrimaryKey(primaryKey);
Review Comment:
This bug fix has no regression test, so both changed storage paths can
regress without detection. Please add a real-segment test in
`DimensionTableDataManagerTest`, parameterized with `disablePreload` true and
false, that loads a BYTES primary key and verifies `containsKey`/`lookupValues`
using a content-equivalent `ByteArray` probe. The existing mocked transform
test cannot exercise this stored-key representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
