Jackie-Jiang commented on code in PR #19027:
URL: https://github.com/apache/pinot/pull/19027#discussion_r3787504067
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -381,6 +381,14 @@ public static class Broker {
"pinot.broker.query.log.sqlRedaction";
public static final String DEFAULT_BROKER_QUERY_LOG_SQL_REDACTION = "none";
public static final String CONFIG_OF_BROKER_QUERY_ENABLE_NULL_HANDLING =
"pinot.broker.query.enable.null.handling";
+ /// How query option keys supplied through SQL `SET` / `OPTION(...)` on
DQL queries are validated.
+ /// One of `QueryOptionsUtils.SqlQueryOptionValidationMode`: `NONE`
(default, unknown keys are
+ /// preserved silently, as they always have been), `WARN` (preserved,
logged once per distinct
+ /// unknown key) or `REJECT` (query fails). Plugins can allowlist their
own keys for `REJECT` via
+ /// `QueryOptionsUtils.registerSqlQueryOptionKey`.
+ public static final String CONFIG_OF_BROKER_QUERY_OPTION_VALIDATION_MODE =
Review Comment:
To follow existing config key convention,
`pinot.broker.query.option.validationMode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
