xiangfu0 commented on code in PR #19236:
URL: https://github.com/apache/pinot/pull/19236#discussion_r3798326434


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/Obfuscator.java:
##########
@@ -66,11 +68,14 @@ public final class Obfuscator {
 
   private final String _maskedValue;
   private final List<Pattern> _patterns;
+  private final boolean _useDefaultCredentialPolicy;
 
   /// Obfuscator with default behavior matching (ignore case) "secret", 
"password", and "token" suffixes. Masks any
   /// values with '\*\*\*\*\*'
   public Obfuscator() {
-    this(DEFAULT_MASKED_VALUE, DEFAULT_PATTERNS);
+    _maskedValue = DEFAULT_MASKED_VALUE;
+    _patterns = DEFAULT_PATTERNS;
+    _useDefaultCredentialPolicy = true;

Review Comment:
   Fixed in 25cc6b4026. The public constructor documentation now describes the 
shared sensitive-name policy, structured assignment and URI masking, 
whole-placeholder preservation, and the default marker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to