xiangfu0 opened a new pull request, #19282: URL: https://github.com/apache/pinot/pull/19282
Extracted from #18229 as an independent correctness prerequisite. BaseChunkForwardIndexReader previously allocated a separate decoded buffer for DELTA and DELTADELTA without storing it in ChunkReaderContext. The first read returned correct data, but later reads in the same chunk reused the untouched context buffer. The extra direct allocation also escaped the context lifecycle. This change decodes every compression type into the context-owned full-chunk buffer and invalidates the cached chunk id before decoding so failures cannot leave a false cache hit. Tests: - FixedByteChunkSVForwardIndexTest covers INT and LONG with DELTA and DELTADELTA - same-chunk reads, cross-chunk transitions, partial final chunk, and chunk revisits - the full test class passes 78 tests - pinot-segment-local Spotless, Checkstyle, license format, and license check This PR does not add codec-pipeline behavior and can merge independently of the codec stack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
