xiangfu0 commented on code in PR #19284:
URL: https://github.com/apache/pinot/pull/19284#discussion_r3800585146
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexCreatorFactory.java:
##########
@@ -51,6 +51,7 @@ public static ForwardIndexCreator
createIndexCreator(IndexCreationContext contex
File indexDir = context.getIndexDir();
FieldSpec fieldSpec = context.getFieldSpec();
String columnName = fieldSpec.getName();
+ ForwardIndexType.rejectUnsupportedCodecSpec(indexConfig, columnName);
Review Comment:
Addressed in 1c5df46ed6. OPEN_STRUCT validation now rejects codecSpec in
both valueFieldConfigs and defaultValueFieldConfig, and
OpenStructColumnSplitter independently checks the resolved child
ForwardIndexConfig immediately before replacing it with LZ4. The direct
splitter and table validation regressions cover both sources. The focused
OpenStruct suite passes 33 tests and the existing layer-1 gate suite passes 171
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
