xiangfu0 commented on code in PR #19287:
URL: https://github.com/apache/pinot/pull/19287#discussion_r3801910230
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/VectorSimilarityFilterOperator.java:
##########
@@ -381,11 +523,14 @@ private ImmutableRoaringBitmap executeSearch() {
return annResults;
} finally {
- // Record search metrics for observability — always, regardless of which
path was taken
- VectorSearchMetrics.getInstance().recordSearch(_vectorSearchMode,
_backendType);
+ if (searchExecuted) {
+ VectorSearchMetrics.getInstance().recordSearch(_vectorSearchMode,
_backendType);
+ }
// Refresh explain context with the final search mode decided during
execution
- refreshExplainContext(null);
- clearBackendParams(column);
+ refreshExplainContext();
+ if (backendParamsConfigured) {
+ clearBackendParams(column);
+ }
Review Comment:
Addressed by the same exception-safety fix in 2c163f07e9: cleanup is armed
before backend configuration and runs from an inner finally even if
configuration only partially succeeds. The regression verifies the cleanup
calls after an injected setter failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
