xiangfu0 opened a new pull request, #19298:
URL: https://github.com/apache/pinot/pull/19298
Part 2/5 of the split of #19287 (Fix FULL-upsert vector candidate
generation).
## Summary
Two robustness fixes in `VectorSimilarityFilterOperator.executeSearch`:
- Only record a vector search metric when a search actually executed.
Previously a
failure inside `configureBackendParams` still recorded a search that never
ran.
- Guarantee backend search parameters are cleared even when configuration
fails partway
through the setters or the explain-context refresh throws, by claiming
cleanup before
the first setter and clearing in a nested finally. Backend search
parameters
(`nprobe`, `efSearch`) are ThreadLocal overrides on shared per-segment
readers, so a
skipped cleanup leaks a stale override onto a pooled query thread where it
silently
applies to a later query's search.
Part 4/5 relies on this hardening for its early-return exact-scan path.
## Validation
- `VectorSimilarityFilterOperatorTest`: 23 tests passed, including the new
`testBackendParamsAreClearedWhenConfigurationFailsPartway`.
> Stacked on #19297 — this PR shows its commits until that merges; review
only the last commit here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
