davecromberge commented on PR #18633: URL: https://github.com/apache/pinot/pull/18633#issuecomment-5358858334
Closing. JMH showed the win is confined to theta (CpcSketch/TupleSketch only expose heapify, so they materialise on the heap regardless) and amounts to ~1% of full-query time, within measurement noise. Not worth the forward-index SPI surface, especially as the datasketches 9 MemorySegment migration would require rewriting the whole change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
