xiangfu0 opened a new pull request, #19327: URL: https://github.com/apache/pinot/pull/19327
## Summary - add `TableNameBuilder.quoteTableNameWithType` for reusable typed-table SQL quoting - quote optional database and table components separately - escape embedded double quotes while preserving the existing non-whitespace character contract - reject malformed qualification and missing canonical table-type suffixes ## Motivation Callers that construct internal SQL currently need to quote typed table resource names themselves. Quoting a whole database-qualified name changes its meaning, while an ASCII allowlist would reject table names Pinot currently permits. This helper centralizes the component-aware and injection-safe behavior in `pinot-spi`. ## Validation - `TableNameBuilderTest` (4 tests, 0 failures) - `spotless:apply -pl pinot-spi` - `license:format -pl pinot-spi` - `checkstyle:check -pl pinot-spi` - `license:check -pl pinot-spi` - `test-compile -pl pinot-spi -am` with added-line `-Xlint:all` review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
