shounakmk219 commented on code in PR #19180:
URL: https://github.com/apache/pinot/pull/19180#discussion_r3844462705
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseSingleSegmentConversionExecutor.java:
##########
@@ -142,6 +141,38 @@ public SegmentConversionResult executeTask(PinotTaskConfig
pinotTaskConfig)
reportTaskProcessingMetrics(tableNameWithType, taskType,
segmentMetadata.getTotalDocs());
}
+ SegmentZKMetadataCustomMapModifier segmentZKMetadataCustomMapModifier =
Review Comment:
Just wondering this should not introduced any regression on custom tasks
which extend the `BaseSingleSegmentConversionExecutor`. Skipping tar + upload
feels more like a task specific behaviour so it would be better to have the
control at per task while keeping the default behaviour as current behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
