Jackie-Jiang opened a new pull request, #19351: URL: https://github.com/apache/pinot/pull/19351
## Summary Supersedes #19345, where every CI job fails because the checkstyle config no longer loads under checkstyle 14. - Bump `com.puppycrawl.tools:checkstyle` from 10.26.1 to 14.0.0. - Remove the `JavadocStyle` module from `config/checkstyle.xml`: the check was removed upstream in checkstyle 13.9.0. Its suggested replacement (`SummaryJavadoc`) only covers first-sentence checking, which we had explicitly disabled (`checkFirstSentence=false`), and the module only ever inspected `/** */` comments, which the codebase has already migrated away from in favor of `///` markdown doc comments — so it was dead weight rather than something to replace. - Reformat two lambda bodies in `CompoundPinotMetricsFactory` that the tightened `Indentation` check in checkstyle 14 flags. Verified by cross-checking every module in `config/checkstyle.xml` against the checkstyle 14.0.0 jar (`JavadocStyle` was the only removed one) and running the standalone checkstyle 14.0.0 CLI with our config over all Java sources and `.properties` resources — zero violations on files the Maven plugin scans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
