This is an automated email from the ASF dual-hosted git repository.
Jackie-Jiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 79914387d95 Upgrade checkstyle from 10.26.1 to 14.0.0 (#19351)
79914387d95 is described below
commit 79914387d952e839da69438bc19f87e92ab0a942
Author: Xiaotian (Jackie) Jiang <[email protected]>
AuthorDate: Mon Aug 24 15:26:35 2026 -0700
Upgrade checkstyle from 10.26.1 to 14.0.0 (#19351)
---
config/checkstyle.xml | 7 -----
.../compound/CompoundPinotMetricsFactory.java | 30 ++++++++++------------
pom.xml | 2 +-
3 files changed, 15 insertions(+), 24 deletions(-)
diff --git a/config/checkstyle.xml b/config/checkstyle.xml
index 5954306729f..f7beae7967f 100644
--- a/config/checkstyle.xml
+++ b/config/checkstyle.xml
@@ -223,13 +223,6 @@
value="Use /// markdown doc comments (JEP 467) instead of /**
*/ Javadoc."/>
</module>
- <!-- If you have a Javadoc comment, make sure it is properly formed.
- NOTE: this only inspects /** */ comments, so it no longer applies to
the /// doc
- comments that the codebase now uses. -->
- <module name="JavadocStyle">
- <property name="checkFirstSentence" value="false"/>
- </module>
-
<!-- NAMING CONVENTIONS -->
<!-- Generic parameters for a class must be uppercase letters (e.g. <T>,
<OLD>) -->
diff --git
a/pinot-plugins/pinot-metrics/pinot-compound-metrics/src/main/java/org/apache/pinot/plugin/metrics/compound/CompoundPinotMetricsFactory.java
b/pinot-plugins/pinot-metrics/pinot-compound-metrics/src/main/java/org/apache/pinot/plugin/metrics/compound/CompoundPinotMetricsFactory.java
index 3e97e6c2413..c708909ab38 100644
---
a/pinot-plugins/pinot-metrics/pinot-compound-metrics/src/main/java/org/apache/pinot/plugin/metrics/compound/CompoundPinotMetricsFactory.java
+++
b/pinot-plugins/pinot-metrics/pinot-compound-metrics/src/main/java/org/apache/pinot/plugin/metrics/compound/CompoundPinotMetricsFactory.java
@@ -184,13 +184,12 @@ public class CompoundPinotMetricsFactory implements
PinotMetricsFactory {
protected Stream<PinotMetricsFactory> streamInstances(PinotConfiguration
metricsConfiguration) {
return PinotMetricUtils.getPinotMetricsFactoryClasses().stream()
.map(clazz -> {
- try {
- return (PinotMetricsFactory)
clazz.getDeclaredConstructor().newInstance();
- } catch (Exception ex) {
- throw new IllegalArgumentException("Cannot instantiate
class " + clazz, ex);
- }
- }
- );
+ try {
+ return (PinotMetricsFactory)
clazz.getDeclaredConstructor().newInstance();
+ } catch (Exception ex) {
+ throw new IllegalArgumentException("Cannot instantiate class "
+ clazz, ex);
+ }
+ });
}
},
/// An algorithm returns all the factories listed in the config under the
[#LIST_KEY].
@@ -199,15 +198,14 @@ public class CompoundPinotMetricsFactory implements
PinotMetricsFactory {
protected Stream<PinotMetricsFactory> streamInstances(PinotConfiguration
metricsConfiguration) {
return metricsConfiguration.getProperty(LIST_KEY, List.of()).stream()
.map(className -> {
- try {
- return PluginManager.get().createInstance(className);
- } catch (ClassNotFoundException ex) {
- throw new IllegalArgumentException("Cannot find metric
factory named " + className, ex);
- } catch (Exception ex) {
- throw new IllegalArgumentException("Cannot instantiate
class " + className, ex);
- }
- }
- );
+ try {
+ return PluginManager.get().createInstance(className);
+ } catch (ClassNotFoundException ex) {
+ throw new IllegalArgumentException("Cannot find metric factory
named " + className, ex);
+ } catch (Exception ex) {
+ throw new IllegalArgumentException("Cannot instantiate class "
+ className, ex);
+ }
+ });
}
};
diff --git a/pom.xml b/pom.xml
index 0f7eb5033d1..a23d927e34b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2534,7 +2534,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>10.26.1</version>
+ <version>14.0.0</version>
</dependency>
</dependencies>
<executions>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
