tarun11Mavani commented on code in PR #19314:
URL: https://github.com/apache/pinot/pull/19314#discussion_r3860057539
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/openstruct/MutableOpenStructIndex.java:
##########
@@ -98,6 +102,10 @@ public void index(int docId, @Nullable Object value) {
Map<String, Object> map = (Map<String, Object>) value;
for (Map.Entry<String, Object> entry : map.entrySet()) {
String key = entry.getKey();
+ if (_config.isIgnoredKey(key)) {
Review Comment:
Good catch. swapped the order so the null check runs first.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/openstruct/MutableOpenStructIndex.java:
##########
@@ -282,6 +290,13 @@ public DataType getStoredType() {
@Override
public void close()
throws IOException {
+ if (_ignoredKeyDropCount > 0) {
Review Comment:
Left as-is: close()/seal() are already single-shot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
