xiangfu0 commented on PR #19273: URL: https://github.com/apache/pinot/pull/19273#issuecomment-5448846788
Addressed the change-request review on head `0d06aeda6916e6113baa6afbdf2d4085e582a1a7`: - Completed the requested split. This PR now contains only sealed V2-V6 selective reads. - Removed the grouped projection path entirely, so the typed conversion issue, first-block lazy registration, missing grouped-wiring counter, live mutable list, and raw-reader API concerns are no longer in this PR. - Added legacy V2/V3 MAP tests for compressed and pass-through chunks. The tests cover present string/numeric values, absent keys, full-map parity, and pin both optimized overloads so they fail if dispatch falls back to full-map materialization. - Kept the existing V4 test matrix, inherited by V5/V6 across every compression type. - Added like-for-like sealed object and string benchmark pairs; the benchmark class documents thread ownership. - Rewrote the branch as one human-authored commit with no AI co-author trailer. Local validation: 164 focused tests pass, `pinot-perf` compiles, and Spotless, Checkstyle, license formatting, and license checks pass for the affected modules. Fresh CI is running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
