Jackie-Jiang opened a new pull request, #19389:
URL: https://github.com/apache/pinot/pull/19389

   ## Summary
   
   `MinionTaskTestUtils.assertNoTaskSchedule` asserts 
`assertNotNull(info.getScheduledTaskNames())` first, but null task names are 
the "no task scheduled due to scheduling errors" convention — and the actual 
cause is recorded in the info's `generationErrors` / `schedulingErrors`, which 
the bare null assertion discards. A CI failure then reads only `expected object 
to not be null`, and since several scheduling-failure branches record the error 
exclusively in the response (no WARN/ERROR log), the cause is unrecoverable 
from the run.
   
   This change folds both error lists into the assertion message, so a failure 
self-identifies:
   
   ```
   Scheduling failed with generation errors: [Failed to register batch for plan 
...], scheduling errors: []
   ```
   
   Test-utility-only change; assertion semantics are unchanged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to