Jackie-Jiang opened a new pull request, #19392: URL: https://github.com/apache/pinot/pull/19392
## Summary `OfflineClusterIntegrationTest.checkTableSetup` is an `@AfterMethod` that asserts the table returned to its pre-test state, and it compares `getTableSize()` against the recorded size instantly. Table size is server-reported and transiently returns `-1` while a segment reload from the preceding test is still in flight (e.g. right after `testForwardIndexTriggering`), so the check occasionally fails with `expected [20318824] but found [-1]` ([example run](https://github.com/apache/pinot/actions/runs/33211824921/job/98986582618)). The blast radius makes this worse than a normal flake: a failed `@AfterMethod` is a TestNG configuration failure, so a single transient `-1` skipped the remaining 82 tests of the class in that run, and the failure attaches to whichever test happened to run before it. The size check now polls until the size converges back to the recorded value (60s bound, same idiom as the file's other waits). This is also semantically truer to the assertion's intent: the config and schema asserts stay strict since they are deterministic ZK reads, while a test that genuinely changed the table never converges and still fails, now with an explicit "Table size did not converge back to ..." message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
