This is an automated email from the ASF dual-hosted git repository.
Jackie-Jiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new bd69e76f14e Fix checkTableSetup table-size flake by polling until the
size converges (#19392)
bd69e76f14e is described below
commit bd69e76f14e042d39cba2d4902249143ad793927
Author: Xiaotian (Jackie) Jiang <[email protected]>
AuthorDate: Fri Aug 28 17:12:12 2026 -0700
Fix checkTableSetup table-size flake by polling until the size converges
(#19392)
---
.../integration/tests/OfflineClusterIntegrationTest.java | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
index 6872360a874..e59cf4ebe85 100644
---
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
+++
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
@@ -308,11 +308,19 @@ public class OfflineClusterIntegrationTest extends
BaseClusterIntegrationTestSet
/// Ensure table is at the same state after the test.
@AfterMethod
- public void checkTableSetup()
- throws IOException {
+ public void checkTableSetup() {
assertEquals(getOfflineTableConfig(), _tableConfig);
assertEquals(getSchema(getTableName()), _schema);
- assertEquals(getTableSize(getTableName()), _tableSize);
+ // Table size is reported by the servers and transiently returns -1 while
a segment reload from the preceding test
+ // is still in flight, so poll until it converges. A test that actually
changed the table never converges and still
+ // fails, and a failure here is a configuration failure that skips all
remaining tests in the class.
+ TestUtils.waitForCondition(aVoid -> {
+ try {
+ return getTableSize(getTableName()) == _tableSize;
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ }, 60_000L, "Table size did not converge back to " + _tableSize);
}
private void reloadAllSegments(String testQuery, boolean forceDownload, long
numTotalDocs)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
