xiangfu0 commented on PR #19396: URL: https://github.com/apache/pinot/pull/19396#issuecomment-5492145419
@gortiz I rebased this onto current `master` and refactored it around the coordination feedback. - Sender sorting is now owned by an explicit `SortNode` / `SortOperator`; `MailboxSendOperator` no longer performs sorting and only advertises a guarantee it can structurally verify. - Ordered-window fan-in now uses a dedicated `SortedMailboxMergeReceiveOperator`, leaving the legacy `SortedMailboxReceiveOperator` execution path intact. That isolates the overlap with #19121 while #19120 and #19122 remain complementary producer/consumer work. - This follows the ownership direction in #19412. If #19412 lands first, the remaining overlap should be mechanical rather than two competing sender-sort implementations. - Mixed-version behavior is safe in either upgrade direction: missing per-block confirmation falls back to the legacy full receiver sort before output, while old receivers retain `sortOnReceiver = true`. Validation on head `f151331206ca6a13157b1d93e55bb889d4c39c25`: the 20-module runtime reactor passed (planner 1,540 tests; runtime 4,640 tests, 18 skips), 348 focused planner/runtime tests passed, all four hygiene gates passed for planner/runtime/perf, and the eight-domain Pinot review completed with no remaining findings. The refreshed 400k-row matched JMH comparison was noisy in both directions, so I reported the raw values in the PR body without making a performance claim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
