J-HowHuang commented on PR #19386: URL: https://github.com/apache/pinot/pull/19386#issuecomment-5499000277
@Jackie-Jiang > The fallback recomputes the step with stepBudget=null, deliberately allowing servers to exceed the initial/target byte ceiling. Because pre-checks are optional and do not gate execution, a full server can still exhaust disk. Please abort with the blocked servers and required bytes, or require a separate explicit, default-off override for unsafe continuation. I'm planning on aborting rebalance when disk utilization check failed mid-fly, I think it would be a better place to put the protection since it also account for any disk usage increase from other operations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
