xiangfu0 commented on PR #19303: URL: https://github.com/apache/pinot/pull/19303#issuecomment-5503267962
Addressed the follow-up scope review in `265c9da852` and rebased the PR onto current `master` (`9fd510fe81`). - Removed both benchmark implementations while retaining their measurements in the PR description. - Reverted the unrelated immutable-HNSW and IVF changes/tests, SPI/comment-only churn, and redundant mutable-index edge tests. - Added a mode-only strategy path so `FilterPlanNode` does not eagerly format explanations. - Removed the shared-worker re-interrupt while preserving the interruption as the `IOException` cause. - Kept the sparse exact-scan strategy, generation-based refresh coalescing, shared `BaseFilterQuery`, realtime integration coverage, and FULL-upsert coverage. - Applied the three inline requests: `BaseFilterQuery` naming, `DataType` import, and static TestNG assertions. Validation on the rebased patch: 69 focused unit tests and 8 integration tests pass; both integration commands completed the full 63-module reactor successfully. Spotless, Checkstyle, license format, and license check pass on all three affected modules. The dense FULL-upsert-plus-filtered-ANN fixture and newer-generation-behind-in-flight-refresh test remain intentionally out of scope as the review marked both coverage gaps non-blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
