Jackie-Jiang opened a new pull request, #19436:
URL: https://github.com/apache/pinot/pull/19436

   ## Summary
   
   - prefer inline review findings with a concise overall summary
   - strengthen guidance for lean, human-reviewable PRs and consistent naming 
across related classes
   - clarify that benchmark results are preferred while disposable benchmark 
classes do not need to be committed
   - keep related tests concise and together
   - add minor Java conventions for static Assert/Mockito imports, direct 
data-type imports, and multiline ternary formatting
   
   ## Validation
   
   - git diff --check
   - verified all 167 review principle IDs are unique
   
   Documentation and review-guidance changes only; no Maven tests were run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to