xiangfu0 commented on code in PR #19379:
URL: https://github.com/apache/pinot/pull/19379#discussion_r3919145977
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DefaultGroupByExecutor.java:
##########
@@ -184,6 +187,7 @@ private Map<ExpressionContext, Integer>
getGroupByExpressionSizesFromPredicates(
// Populate the group-by expressions with sizes from the predicate map
return queryContext.getGroupByExpressions().stream()
.filter(predicateSizeMap::containsKey)
+ .filter(expression ->
projectOperator.getResultColumnContext(expression).isSingleValue())
.collect(Collectors.toMap(
Review Comment:
Good catch — added `Integer::min` as the merge function (in 34abecb63c), so
`GROUP BY c0, c0` no longer throws and the duplicate-expression handling in
`getOptimizedGroupByCardinality` is now reachable; also added a `GROUP BY s1,
s1` regression case to the capacity data provider.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
