xiangfu0 commented on PR #19264: URL: https://github.com/apache/pinot/pull/19264#issuecomment-5548085576
CI is green on `eab759f` — all 12 checks pass: - Unit Test Set 1 & 2 (incl. `DeriveGroupingSetsTest` and `StreamingGroupByCombineOperatorTest`) - Integration Test Set 1 & 2 (`GroupingSetsQueriesTest`) - Compatibility Regression vs. master and vs. release-1.5.0 (SSE + MSE) — mixed-version safe - Linter, Binary Compatibility, Java 11 Client, Quickstart The PR is mergeable and ready for review. The base-aggregation path is enabled by default (`groupingSetsBaseAggregation`), and the server-side per-set trim (`groupingSetsServerTrimSize`) is opt-in / exact-by-default (broker applies the final ORDER BY + LIMIT). Happy to flip the server-trim default to bounded (`minServerGroupTrimSize`) if reviewers prefer a memory-bounded default — otherwise it ships exact-by-default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
