Jackie-Jiang opened a new pull request, #19482: URL: https://github.com/apache/pinot/pull/19482
## Summary `MultiValueLimit` in `MutableSegmentImpl` declares its record components with the `_` field prefix, so its generated accessors are `_column()` and `_maxNumMultiValues()`, and its call sites read the backing fields directly (`limit._column`). A record component names the generated accessor, which makes it API rather than private member state. The `_` prefix exists for the latter — checkstyle's `MemberName` mandates `^_[a-z][a-zA-Z0-9]*$` for member variables, but record components are `RECORD_COMPONENT_DEF` and fall outside that check, which is why the prefixed form passes silently. Semantically they are closer to the canonical constructor's parameters, and `ParameterName` requires plain camelCase there. Every other record in the codebase uses plain names. This renames the components to `column` and `maxNumMultiValues` and reads them through the accessors instead of the fields. No behavior change. The record is `private` to `MutableSegmentImpl`, its components were read in exactly one method (`validateNumMultiValues`), and no other file references them — the identically named `_maxNumMultiValues` fields in `MutableIndexContext` and `FixedByteMVMutableForwardIndex` are genuine private members and are untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
