anuragrai16 commented on code in PR #19450:
URL: https://github.com/apache/pinot/pull/19450#discussion_r3946543236
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -178,6 +179,12 @@ public boolean isFinal() {
}
}
+ protected enum BuildSegmentResult {
+ SUCCESS,
+ FAILURE,
+ CRC_MISMATCH
Review Comment:
The list is slightly confusing, CRC_MISMATCH is the reason why a segment
should be downloaded or not, while SUCCESS/FAILURE represent whether the
download was succesful or not. Combining them can cause confusion for readers.
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -178,6 +179,12 @@ public boolean isFinal() {
}
}
+ protected enum BuildSegmentResult {
Review Comment:
Add java-doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
