KKcorps opened a new pull request, #19487: URL: https://github.com/apache/pinot/pull/19487
Metadata push can throw after the controller has registered the segment URI, for example when the client loses the response. Executors that publish a fresh immutable URI per attempt need to retain that output until they reconcile controller metadata. Extract the existing failure deletion into a protected `cleanupMetadataPushFailure(PinotFS, URI)` hook. This lets those executors defer cleanup without duplicating the single-segment conversion/upload lifecycle. The default implementation retains the existing deletion behavior, and the upload exception still propagates to fail the task. Validation: all four `BaseSingleSegmentConversionExecutorTest` cases passed, including the existing cleanup test and a new override test that retains the output while propagating the error. Sources were recompiled and run with TestNG against the locally cached dependency classpath. The Maven test lifecycle was blocked by uncached `protobuf-java:4.36.1` and `snakeyaml:2.7`; CI still needs to validate current dependency resolution. Module-scoped Spotless, Checkstyle, license format/check, and `git diff --check` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
