tarun11Mavani commented on code in PR #19093:
URL: https://github.com/apache/pinot/pull/19093#discussion_r3975786046
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/impl/openstruct/OpenStructColumnSplitterTest.java:
##########
@@ -219,7 +220,17 @@ public void testSparseJsonColumnWritten()
}
s.seal();
String sparseCol = OpenStructNaming.sparseColumnName("metrics");
- assertTrue(s.getMaterializedColumnMetadata().containsKey(sparseCol));
+ PropertiesConfiguration props =
s.getMaterializedColumnMetadata().get(sparseCol);
+ assertNotNull(props);
+
+ // Regression: the sparse column's metadata used to omit several
properties ColumnMetadataImpl.
+ // fromPropertiesConfiguration() reads via config.getInt() with no default
(e.g. CARDINALITY). This branch's
+ // reader still tolerates a missing
bitsPerElement/lengthOfEachEntry/maxNumberOfMultiValues via UNAVAILABLE
+ // defaults, but the sibling early-release branch's stricter reader throws
NoSuchElementException on the same
Review Comment:
Reworded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
