KKcorps commented on PR #19504: URL: https://github.com/apache/pinot/pull/19504#issuecomment-5674786981
Closing this PR so we can prioritize making `SYNC` or `SNAPSHOT` the default upsert consistency mode. The existing consistency-mode path avoids the long-lived stale-bitmap copy behind Coupang’s observed compaction false positive and provides consistent query views. Before changing the default, we need to address compatibility gaps—especially the current disabling of `dropOutOfOrderRecord` and `outOfOrderRecordColumn` in these modes—and validate freshness, memory usage, and query/ingestion performance. We will defer the replacement-row comparison approach in this PR and retain the existing metric as a diagnostic signal. Neither consistency mode makes that metric a complete detector of partial-upsert divergence. Existing tables will need an explicit migration plan when a new default is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
