deepthi912 commented on code in PR #19505:
URL: https://github.com/apache/pinot/pull/19505#discussion_r4020784543
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -250,14 +250,17 @@ protected void revertAndRemoveSegment(IndexSegment
segment,
prevDocId, recordInfo);
return prevLocation;
} catch (Exception e) {
- _logger.error("Failed to revert to previous segment: {},
removing key", prevSegment.getSegmentName(),
- e);
+ _logger.error("UPSERT_METADATA_REVERT_FAILED: segment={}.
Failed to revert to previous segment: {}, "
Review Comment:
Can you add the same metric for the
`ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletes` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
