Jackie-Jiang commented on a change in pull request #4859: Enhance TagNameUtils
to handle the TagOverrideConfig
URL: https://github.com/apache/incubator-pinot/pull/4859#discussion_r350941233
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/TagNameUtils.java
##########
@@ -27,78 +28,93 @@ private TagNameUtils() {
}
public final static String DEFAULT_TENANT_NAME = "DefaultTenant";
+ private final static String BROKER_TAG_SUFFIX = "_" + TenantRole.BROKER;
+ private final static String OFFLINE_SERVER_TAG_SUFFIX = "_" +
ServerType.OFFLINE;
+ private final static String REALTIME_SERVER_TAG_SUFFIX = "_" +
ServerType.REALTIME;
- private static String buildRealtimeTagFromTenantName(String tenantName) {
- return tenantName + "_" + ServerType.REALTIME.toString();
- }
-
- private static String buildOfflineTagFromTenantName(String tenantName) {
- return tenantName + "_" + ServerType.OFFLINE.toString();
- }
-
- private static String buildBrokerTenantTagFromTenantName(String tenantName) {
- return tenantName + "_" + TenantRole.BROKER.toString();
+ public static boolean isBrokerTag(String tagName) {
+ return tagName.endsWith(BROKER_TAG_SUFFIX);
}
public static boolean isServerTag(String tagName) {
return isOfflineServerTag(tagName) || isRealtimeServerTag(tagName);
}
public static boolean isOfflineServerTag(String tagName) {
- return tagName.endsWith(ServerType.OFFLINE.toString());
+ return tagName.endsWith(OFFLINE_SERVER_TAG_SUFFIX);
}
public static boolean isRealtimeServerTag(String tagName) {
- return tagName.endsWith(ServerType.REALTIME.toString());
+ return tagName.endsWith(REALTIME_SERVER_TAG_SUFFIX);
}
- public static boolean isBrokerTag(String tagName) {
- return tagName.endsWith(TenantRole.BROKER.toString());
+ public static String getTenantFromTag(String tagName) {
Review comment:
Simplified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
