This is an automated email from the ASF dual-hosted git repository.
Jackie-Jiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ef75ed97148 Remove unused 5-arg getValidDocIdFromServerMatchingCrc
overload (#19585)
ef75ed97148 is described below
commit ef75ed97148f5eb294e544b9185a34837cd5b358
Author: Chaitanya Deepthi <[email protected]>
AuthorDate: Thu Sep 17 09:18:27 2026 -0700
Remove unused 5-arg getValidDocIdFromServerMatchingCrc overload (#19585)
---
.../pinot/plugin/minion/tasks/MinionTaskUtils.java | 25 ++++++----------------
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git
a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java
b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java
index 24878151a47..08edf4cecce 100644
---
a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java
+++
b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java
@@ -327,27 +327,16 @@ public class MinionTaskUtils {
return defaultValue;
}
- /// Returns the validDocIds bitmap for the segment resolved across the
server(s) hosting it, per the consensus mode
- /// (`comparisonModeStr` is the task config value):
- /// - `UNSAFE`: the first usable server bitmap; servers that fail, mismatch
the CRC, or are not READY are skipped.
+ /// Returns the validDocIds bitmap for the segment, resolved across the
servers hosting it. A server contributes
+ /// its bitmap only when its CRC matches `expectedCrc`, or - when segment
CRCs differ - when `expectedDataCrc`
+ /// matches (see [#crcMatches]). `comparisonModeStr` selects the resolution
mode:
+ /// - `UNSAFE`: first usable bitmap; failing / mismatched / non-READY
servers are skipped.
/// - `EQUAL` (default): the bitmap every server agrees on.
/// - `MOST_VALID_DOCS`: the bitmap with the highest valid-doc count.
///
- /// Returns null when no server produced a usable bitmap (no server hosts
the segment, or every server was skipped
- /// in `UNSAFE` mode). In the non-`UNSAFE` modes any failure throws instead
of being skipped:
- /// - [NotFoundException] when a server has no validDocIds for the segment
(e.g. the snapshot is not written yet, or
- /// the segment is not hosted) — a distinct condition that callers may
handle with a documented fallback.
- /// - [IllegalStateException] for any other fetch failure, a CRC mismatch
(typically the server still reloading the
- /// segment), a server not in GOOD status, or an `EQUAL`-mode consensus
failure.
- @Nullable
- public static RoaringBitmap getValidDocIdFromServerMatchingCrc(String
tableNameWithType, String segmentName,
- String validDocIdsType, MinionContext minionContext, String expectedCrc,
String comparisonModeStr) {
- return getValidDocIdFromServerMatchingCrc(tableNameWithType, segmentName,
validDocIdsType, minionContext,
- expectedCrc, null, comparisonModeStr);
- }
-
- /// Variant that also matches on the expected data CRC (see [#crcMatches]),
with the same return and exception
- /// contract as [#getValidDocIdFromServerMatchingCrc(String, String, String,
MinionContext, String, String)].
+ /// Returns null if no server produced a usable bitmap. Non-`UNSAFE` modes
throw instead of skipping:
+ /// [NotFoundException] when a server has no validDocIds (e.g. snapshot not
yet written); [IllegalStateException]
+ /// for other fetch failures, CRC mismatches, non-GOOD status, or
`EQUAL`-mode consensus failures.
@Nullable
public static RoaringBitmap getValidDocIdFromServerMatchingCrc(String
tableNameWithType, String segmentName,
String validDocIdsType, MinionContext minionContext, String expectedCrc,
@Nullable String expectedDataCrc,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
