Jackie-Jiang commented on PR #19367: URL: https://github.com/apache/pinot/pull/19367#issuecomment-5722969422
@yashmayya Thanks, both were real, and both turned out to be general null-handling gaps rather than star-tree ones, so they were fixed on master first and this PR is now rebased on them: - **Grouping by a null dimension.** #19390 makes null-handling group-by use `DictionaryBasedGroupKeyGenerator` for dictionary-encoded columns, with `dictionary.length()` as the reserved null id. That is exactly the id this tree stores, so the reserved id no longer reaches the dictionary at all. - **Always-true predicate.** #19440 keeps an always-true predicate on a column with nulls instead of dropping it, in the leaf filter and in `StarTreeUtils`. The column reaches the null check, and on a null-aware tree the matching ids are bounded by the dictionary, so the null child is never traversed. The two tests that reproduced them stay in `NullAwareStarTreeQueriesTest`, which now also covers exclusive and negated predicates, a filtered group-by, an all-null metric group, both build modes, and routing between the two variants in one segment. Ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
