Jackie-Jiang opened a new pull request, #19633: URL: https://github.com/apache/pinot/pull/19633
Moves the native Surefire 3.6.0 migration out of #19631 for separate review. Includes the Apache parent 39 → 40 upgrade that enables Surefire 3.6.0. Apache parent 40 upgrades Surefire to 3.6.0, which removes the legacy TestNG provider and `suiteXmlFiles`. The parent-only bump fails while resolving `surefire-testng:3.6.0`, before any tests execute. This change keeps Surefire 3.6.0 and runs TestNG through its native JUnit Platform provider. Replace the seven controller and integration XML suites with JUnit Platform suite declarations, retaining their group filters, class selections, shared lifecycle, and focused method selections. Controller groups use separate executions and report suffixes so results cannot overwrite each other; explicit `-Dtest` selections still run once. Use native Surefire reports instead of the former TestNG reporting workaround. Add regression coverage for shared suite setup/teardown, nonalphabetical class order, group and method filtering, repeated data-provider invocations, and failure propagation. Add a compile-only JetBrains annotations dependency to segment-local because javac needs it to read zstd-jni signatures when deprecation diagnostics are enabled. Validation on JDK 25.0.3 with the Maven wrapper: - Compiled `pinot-common`, `pinot-controller`, and `pinot-integration-tests` with their dependencies: all 63 reactor modules passed with compiler warning/deprecation diagnostics enabled; no warnings in the new Java files. - Full `pinot-spi` test suite: 839 passed. - `TestNGSuiteTest`: 5 passed; `FileIngestionHelperTest`: 24 passed. - Migrated `MultiNodesOfflineSuite`: exactly the four intended integration methods passed. - Root and affected-module Spotless, Checkstyle, license formatting, and license validation passed. - Verified effective Maven profiles, direct-test overrides, and each integration suite's selections against the removed XML definitions. The complete CI matrix remains to be run on the updated branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
