xiangfu0 commented on PR #19477: URL: https://github.com/apache/pinot/pull/19477#issuecomment-5804485510
Restacked onto master (was conflicting). One real conflict, in `StarTreeLoaderUtils`: master added null-aware star-trees after this branch forked, so the dimension `StarTreeDataSource` construction gained a fifth `loadNullValueVector(...)` argument, while this PR replaces the `indexContainerMap.get(dimension)` lookup with the lazy `indexContainerProvider.apply(dimension)`. Both sides are kept — the provider call plus master's null-value-vector argument — matching the shape the untouched metric branch already uses. Confirmed by `NullAwareStarTreeQueriesTest` (10) and `StarTreeNullHandlingQueriesTest` (4) passing, and the branch compiles. _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
