xiangfu0 commented on PR #19523: URL: https://github.com/apache/pinot/pull/19523#issuecomment-5808684284
I'm splitting this PR into smaller pieces for review. These three are independent of each other and target master: - #19645: Keep tied ExprMin/ExprMax rows from every server when merging serialized results. This is a bug on master that this PR also fixed. - #19646: Move polymorphic aggregate construction into per-family providers. Refactor, no behavior change. - #19647: Add the aggregate call binding contract (Thrift and protobuf fields, `AggregateCallBinding`, type resolver). Nothing uses it yet. Thrift was regenerated with 0.21.0. Next, stacked on the contract PR: single-stage and multi-stage binding plumbing, then one PR per aggregate family (FIRST/LAST_WITH_TIME, ARRAY_AGG, MODE, ANY_VALUE, EXPR_MIN/MAX) and gapfill. The behavior-changing families will carry the `backward-incompat` label. I'll keep this PR open as the tracking reference until the stack lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
