J-HowHuang commented on PR #19386: URL: https://github.com/apache/pinot/pull/19386#issuecomment-5810578802
@Jackie-Jiang The PR introduces budget check that's adding ~60ms into each computation inside `getNextAssignment`, changes are in-memory computation, with no ZK access introduced. This should clear the question on the first point. As for the precheck replay, I'm thinking if we can remove it, and then state this low disk mode would do its best effort. Users don't have any actionable even if they see an ERROR on this precheck either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
