VojtechMucha commented on PR #19035: URL: https://github.com/apache/pinot/pull/19035#issuecomment-5833568531
1. gRPC getMap description fixed. 2. TIMESTAMP_ARRAY fixed. Note that this is more like a hot-fix. The problem is wider, query parameters are impacted too, any fractional seconds are truncated. Proper fix is out of scope of this task, I think. 3. pom.xml is fixed, my bad, sorry for that. - getScalar maps JSON -> getString - yes, it's intended. Other options are: -- throw SQLDataException as is done now -- some parsed JsonNode -- ...? - getCalculatedScale - moved to `BigDecimalUtils`. Just changing the scope would not work as it was called from a different package (PinotResultSetTest) - var value = getObject(...) fixed. Thanks for your review and patience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
