akg268 commented on PR #19251: URL: https://github.com/apache/pinot/pull/19251#issuecomment-5856956635
@Jackie-Jiang Addressed the scope-reduction review in bb415bf26d: - removed the unrelated `MutableIndexContext` compatibility constructor - reverted the `SegmentCompletionFSM` / `BlockingSegmentCompletionFSM` changes and legacy reflection fixture - removed the String reason-code parser overloads - removed typed reason propagation through `CommittingSegmentDescriptor` and the flush-threshold changes/tests The remaining implementation is limited to the numeric wire code alongside the legacy reason, nullable `Integer` endpoint binding, normalization at the request boundary, and precedence/unknown-code fallback coverage. Validation: Spotless, license checks, and Checkstyle pass for the affected modules; `SegmentCompletionProtocolTest` passes (4 tests). The controller suites require the project JDK 25 toolchain, which is not available locally, so the refreshed PR CI will provide that verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
