kishoreg opened a new pull request #4866: Removing segment generation config from RecordReader interface URL: https://github.com/apache/incubator-pinot/pull/4866 Related to #4731 refactoring the existing code to prepare for moving RecordReader to pinot-spi module. As of today, RecordReader takes in SegmentGenerationConfig which makes it very hard to extract RecordReader to pinot-spi. current interface `void init(SegmentGenerationConfig config)` new interface `void init(String inputPath, Schema schema, ReaderConfig readerConfig)` Next step: - Move record reader interface to pinot-spi module - Move Schema and related classes - Instantiate record readers dynamically during segment generation (this is optional and might do it later depending on how easy/hard). We don't need it until we last steps
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
