KKcorps commented on code in PR #19505: URL: https://github.com/apache/pinot/pull/19505#discussion_r4129829394
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletes.java: ########## Review Comment: Good call, added it in both ConcurrentMap managers, and the warn now carries the UPSERT_METADATA_REVERT_FAILED marker so the log and meter line up. Also added a test case where the next consuming segment already owns the key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
