codecov-io edited a comment on issue #4866: Removing segment generation config from RecordReader interface URL: https://github.com/apache/incubator-pinot/pull/4866#issuecomment-558984119 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4866?src=pr&el=h1) Report > Merging [#4866](https://codecov.io/gh/apache/incubator-pinot/pull/4866?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/fdfe8a2bde481aa3233a7675fbf4040a330d4b63?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4866?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4866 +/- ## ============================================ - Coverage 57.81% 57.77% -0.04% Complexity 4 4 ============================================ Files 1200 1200 Lines 64659 64658 -1 Branches 9390 9390 ============================================ - Hits 37385 37359 -26 - Misses 24494 24514 +20 - Partials 2780 2785 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4866?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...inot/core/data/readers/GenericRowRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvR2VuZXJpY1Jvd1JlY29yZFJlYWRlci5qYXZh) | `93.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/pinot/core/data/readers/JSONRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvSlNPTlJlY29yZFJlYWRlci5qYXZh) | `86.66% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/core/minion/segment/MapperRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vc2VnbWVudC9NYXBwZXJSZWNvcmRSZWFkZXIuamF2YQ==) | `81.08% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pinot/core/minion/segment/ReducerRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vc2VnbWVudC9SZWR1Y2VyUmVjb3JkUmVhZGVyLmphdmE=) | `90.19% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/pinot/core/data/readers/AvroRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvQXZyb1JlY29yZFJlYWRlci5qYXZh) | `86.2% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...data/readers/MultiplePinotSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvTXVsdGlwbGVQaW5vdFNlZ21lbnRSZWNvcmRSZWFkZXIuamF2YQ==) | `72.22% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/pinot/core/data/readers/CSVRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvQ1NWUmVjb3JkUmVhZGVyLmphdmE=) | `69.81% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ealtime/converter/RealtimeSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvUmVhbHRpbWVTZWdtZW50UmVjb3JkUmVhZGVyLmphdmE=) | `58.33% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...he/pinot/core/data/readers/ThriftRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvVGhyaWZ0UmVjb3JkUmVhZGVyLmphdmE=) | `82% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...e/pinot/core/data/readers/RecordReaderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUmVjb3JkUmVhZGVyRmFjdG9yeS5qYXZh) | `34.78% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | ... and [38 more](https://codecov.io/gh/apache/incubator-pinot/pull/4866/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4866?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4866?src=pr&el=footer). Last update [fdfe8a2...24f8e62](https://codecov.io/gh/apache/incubator-pinot/pull/4866?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
