deepthi912 commented on PR #19749: URL: https://github.com/apache/pinot/pull/19749#issuecomment-5976305310
Closing: the segment is already marked dirty by the forward replaceDocId() when the consuming segment first supersedes the key, and takeSnapshot() only runs at commit, so the dirty flag survives until the revert. A revert is the inverse of a supersede and does not need its own method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
