xiangfu0 commented on code in PR #19737:
URL: https://github.com/apache/pinot/pull/19737#discussion_r4194084146
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/ReingestionResource.java:
##########
@@ -224,13 +241,15 @@ public Response reingestSegment(@PathParam("segmentName")
@Encoded String encode
/// The actual re-ingestion logic, moved into a separate method for clarity.
/// This is essentially the old synchronous logic you had in reingestSegment.
private void doReingestSegment(String realtimeTableName, SegmentZKMetadata
segmentZKMetadata,
- IndexLoadingConfig indexLoadingConfig, @Nullable Semaphore
segmentBuildSemaphore)
+ IndexLoadingConfig indexLoadingConfig, @Nullable Semaphore
segmentBuildSemaphore, long consumptionTimeoutMs)
throws Exception {
String segmentName = segmentZKMetadata.getSegmentName();
try (StatelessRealtimeSegmentWriter writer = new
StatelessRealtimeSegmentWriter(segmentZKMetadata,
indexLoadingConfig, segmentBuildSemaphore)) {
+ LOGGER.info("Starting consumption to re-ingest segment: {} with timeout:
{}ms", segmentName,
+ consumptionTimeoutMs);
writer.startConsumption();
- waitForCondition((Void) -> writer.isDoneConsuming(), CHECK_INTERVAL_MS,
CONSUMPTION_END_TIMEOUT_MS, 0);
+ waitForCondition((Void) -> writer.isDoneConsuming(), CHECK_INTERVAL_MS,
consumptionTimeoutMs, 0);
Review Comment:
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
