arunkumarucet commented on PR #19760: URL: https://github.com/apache/pinot/pull/19760#issuecomment-6015511856
CI failure fixed in `9a1435f4d1`. Merging `getDocIdsWithOptions` / `getDocIdsWithoutOptions` into one method (review comment on the `buildQuery` javadoc) also merged their exception messages, and the one that survived was the non-options wording. `TextSearchQueriesTest#testTextFilterOptimizerWithWildcardsDifferentOptions` asserts the message contains "Failed while searching the text index", so a leading-wildcard failure under `parser=STANDARD` started reporting unfamiliar text. Restored that wording for the merged method, with a comment naming the test so it does not get tidied away again. Nothing asserts the other phrasing. My miss: the change is in `pinot-segment-local` so that is what I ran, but the callers and this assertion live in `pinot-core`. Now green locally across both: `TextSearchQueriesTest` 17, `TextSearchQueriesWithCombinedFilesTest` 17, `TextSearchMultiColIndexQueriesTest` 16, `TextMatchTransformFunctionTest` 9, `LuceneTextIndexCountTest` 36, plus the rest of the text suite in both modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
