yashmayya commented on code in PR #19759:
URL: https://github.com/apache/pinot/pull/19759#discussion_r4212839545
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -1426,6 +1426,11 @@ public static class Grpc {
public static final String KEY_OF_GRPC_TLS_ENABLED =
"pinot.broker.grpc.tls.enabled";
public static final String KEY_OF_GRPC_TLS_PORT =
"pinot.broker.grpc.tls.port";
public static final String KEY_OF_GRPC_TLS_PREFIX =
"pinot.broker.grpctls";
+ /// Maximum size, in bytes, of a request the broker's gRPC query
endpoint accepts. Must be positive. The default
+ /// is gRPC's default. Queries with large literals (e.g. an `IN_ID_SET`
IdSet of millions of ids) can need more.
+ public static final String KEY_OF_GRPC_MAX_INBOUND_MESSAGE_SIZE_BYTES =
Review Comment:
I've just removed this config, I don't think the broker gRPC query endpoint
is commonly used and it probably doesn't make sense to introduce this config
here just for the potential scenario of large IDSET queries coming through that
endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
