anuragrai16 commented on code in PR #19776:
URL: https://github.com/apache/pinot/pull/19776#discussion_r4214877246
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SplitSegmentCommitter.java:
##########
@@ -77,6 +92,15 @@ public SegmentCompletionProtocol.Response commit(
}
_params.withSegmentLocation(segmentLocation);
+ if (_uploadMetadataTar && _segmentUploader.isMetadataTarUploadSupported()
+ && !isPeerSegmentLocation(segmentLocation)) {
+ String metadataTarLocation =
+ uploadMetadataTarQuietly(segmentBuildDescriptor.getMetadataFiles(),
_params.getSegmentName());
Review Comment:
Should this be after the `commitEndResponse =
_protocolHandler.segmentCommitEndWithMetadata(_params,
segmentBuildDescriptor.getMetadataFiles());` line ?
Currently, a a failed commit leaves a sidecar describing a discarded segment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
