Jackie-Jiang commented on PR #19662: URL: https://github.com/apache/pinot/pull/19662#issuecomment-6089152121
I re-reviewed the latest follow-up commit (`d5e42f3`); the earlier test-coverage and convention comments are addressed, and I found no new functional issue. GitHub currently reports this PR as conflicting with `master`. A read-only merge against current `master` (`910f9d5`) shows one content conflict in `pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java`, at the imports: `master` added `JsonUtils` and this PR added `CommonConstants`. Could you update the branch and resolve that conflict, preserving both imports and the mmap prefetch config wiring? Please confirm the checks pass on the updated head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
